Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 upgrade #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

V4 upgrade #10

wants to merge 2 commits into from

Conversation

websupergirl
Copy link

Upgraded all components + supports to work with Gatsby v4.
Migrated from node-sass to dart-sass to work with current technology.

It still doesn't like the one calc function but it builds fine.

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(100%, 3) or calc(100% / 3)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
19 │             width: calc(#{(100% / 3)} - #{_size(element-margin)});
   │                            ^^^^^^^^
   ╵
    src/assets/scss/components/_features.scss 19:19  @import
    src/assets/scss/main.scss 61:10                  root stylesheet

which comes out on the front end okay as

.features li {
    width: calc(33.3333% - 2em);
    margin-left: 2em;
    margin-top: 3em;
    padding: 0px;
}

If you like this pull request, can you add the hacktoberfest-accepted label?

Screen Shot 2022-10-31 at 11 26 28 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant