Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WITHOUT ROWID to all tables #12

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add WITHOUT ROWID to all tables #12

wants to merge 1 commit into from

Conversation

matt-codecov
Copy link
Collaborator

@matt-codecov matt-codecov commented Jul 30, 2024

this has not made bulk inserts any faster, but it has reduced the resulting SQLite database size for my 110mb test report from 184mb to 105mb (notably, smaller than the input).

we may want to revisit this later when we do more reads

@matt-codecov matt-codecov requested review from Swatinem and removed request for Swatinem July 30, 2024 18:39
@matt-codecov matt-codecov marked this pull request as draft July 30, 2024 18:49
@matt-codecov
Copy link
Collaborator Author

whoops forgot i need to deal with SQLite not liking null local_span_id in the PK for context_assoc. i think i will just remove local_span_id from context_assoc and say, at least for now, that spans must link back to coverage samples somehow

Copy link
Contributor

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though as you mention, we should figure out what the write/merge/read numbers here are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants