Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite->pyreport: stop serializing session_totals, just use null #26

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

matt-codecov
Copy link
Collaborator

@matt-codecov matt-codecov commented Aug 21, 2024

in a report json, each file in the "files" key had a slot for a session_totals field. turns out the field was bugged and also unused, so we're deleting it.

in the pyreport->sqlite code, we always ignored that field and opted to recompute totals on demand later so that code doesn't need to be updated. the sqlite->pyreport code on the other hand gets a good deal simpler and probably faster.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (3fcba40) to head (3372f6b).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   98.62%   98.68%   +0.06%     
==========================================
  Files          17       17              
  Lines        7393     7315      -78     
==========================================
- Hits         7291     7219      -72     
+ Misses        102       96       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-codecov matt-codecov merged commit 87b8459 into main Aug 22, 2024
7 checks passed
@matt-codecov matt-codecov deleted the pr26 branch August 22, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants