Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to cargo workspace + small readme edits #27

Merged
merged 1 commit into from
Aug 28, 2024
Merged

move to cargo workspace + small readme edits #27

merged 1 commit into from
Aug 28, 2024

Conversation

matt-codecov
Copy link
Collaborator

@matt-codecov matt-codecov commented Aug 27, 2024

getsentry/ophio uses a Cargo workspace to separate the core library from the PyO3 bindings. following suit here. benches, tests, and examples all can be invoked same as before, no code needed to change

also removed mentions of mockall from the readme and made other small edits


Stack created with Sapling. Best reviewed with ReviewStack.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (87b8459) to head (595a8df).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          17       17           
  Lines        7315     7315           
=======================================
  Hits         7219     7219           
  Misses         96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-codecov matt-codecov merged commit bd6fe6c into main Aug 28, 2024
7 checks passed
@matt-codecov matt-codecov deleted the pr27 branch August 28, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants