Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tempfile usage in python tests on windows #50

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix tempfile usage in python tests on windows #50

merged 1 commit into from
Sep 24, 2024

Conversation

matt-codecov
Copy link
Collaborator

@matt-codecov matt-codecov commented Sep 20, 2024

https://github.com/codecov/codecov-rs/actions/runs/10949397825/job/30403888643 when building wheels for release, pytest fails on windows because of quirks with windows tempfiles

confirming the fix was kind of a pain but now i have a windows dev environment set up in a VM

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (d29865e) to head (9eb98d8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files          22       22           
  Lines        6776     6776           
=======================================
  Hits         6677     6677           
  Misses         99       99           
Components Coverage Δ
core 98.61% <ø> (ø)
bindings 79.31% <ø> (ø)
python 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-codecov matt-codecov merged commit 5691c1f into main Sep 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants