Refactor ShellExecutable and update error message #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitpaulk
reviewed
Oct 14, 2024
rohitpaulk
reviewed
Oct 14, 2024
|
@ryan-gang bump on this -- just noticed it when working on autofixes for stage 2, where we don't need a long-running process but the logs still say that we do. |
Co-authored-by: Paul Kuruvilla <rohitpaulk@gmail.com>
…gleLineOutputTestCase
rohitpaulk
reviewed
Oct 21, 2024
rohitpaulk
approved these changes
Oct 21, 2024
Co-authored-by: Paul Kuruvilla <rohitpaulk@gmail.com>
|
Thanks @james-clarke for highlighting the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit in this pull request adds the
ExitCodemethod to theShellExecutableclass. This method allows users to retrieve the exit code of the shell process. The second commit updates the error message displayed when encountering an EOF while reading the response. Additionally, it includes the exit code of the shell process in the error message when the first line of output does not end with a newline character.