Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.8: NewsListener::onNewsListCountItems(): Return value must be of type int, false returned #272

Closed
janborg opened this issue Oct 4, 2024 · 1 comment

Comments

@janborg
Copy link

janborg commented Oct 4, 2024

Since updating codefog/contao-news_categories to 4.0.8, I get the following error. Contao 5.3.15

As workaround, I added a conflict for this version in my composer.json

Codefog\NewsCategoriesBundle\EventListener\NewsListener::onNewsListCountItems(): Return value must be of type int, false returned

TypeError:
Codefog\NewsCategoriesBundle\EventListener\NewsListener::onNewsListCountItems(): Return value must be of type int, false returned

  at vendor/codefog/contao-news_categories/src/EventListener/NewsListener.php:39
  at Codefog\NewsCategoriesBundle\EventListener\NewsListener->onNewsListCountItems()
     (vendor/contao/news-bundle/contao/modules/ModuleNewsList.php:178)
  at Contao\ModuleNewsList->countItems()
     (vendor/contao/news-bundle/contao/modules/ModuleNewsList.php:108)
  at Contao\ModuleNewsList->compile()
     (vendor/contao/core-bundle/contao/modules/Module.php:213)
  at Contao\Module->generate()
     (vendor/contao/news-bundle/contao/modules/ModuleNewsList.php:73)
  at Contao\ModuleNewsList->generate()
     (vendor/codefog/contao-news_categories/src/FrontendModule/NewsListModule.php:52)
  at Codefog\NewsCategoriesBundle\FrontendModule\NewsListModule->generate()
     (vendor/contao/core-bundle/contao/library/Contao/Controller.php:405)
  at Contao\Controller::getFrontendModule()
     (vendor/contao/core-bundle/contao/elements/ContentModule.php:59)
  at Contao\ContentModule->generate()
     (vendor/contao/core-bundle/contao/library/Contao/Controller.php:601)
  at Contao\Controller::getContentElement()
     (vendor/contao/core-bundle/contao/modules/ModuleArticle.php:189)
  at Contao\ModuleArticle->compile()
     (vendor/contao/core-bundle/contao/modules/Module.php:213)
  at Contao\Module->generate()
     (vendor/contao/core-bundle/contao/modules/ModuleArticle.php:69)
  at Contao\ModuleArticle->generate()
     (vendor/contao/core-bundle/contao/library/Contao/Controller.php:490)
  at Contao\Controller::getArticle()
     (vendor/contao/core-bundle/contao/library/Contao/Controller.php:356)
  at Contao\Controller::getFrontendModule()
     (vendor/contao/core-bundle/contao/pages/PageRegular.php:177)
  at Contao\PageRegular->prepare()
     (vendor/contao/core-bundle/contao/pages/PageRegular.php:47)
  at Contao\PageRegular->getResponse()
     (vendor/contao/core-bundle/contao/controllers/FrontendIndex.php:65)
  at Contao\FrontendIndex->renderPage()
     (vendor/symfony/http-kernel/HttpKernel.php:181)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw()
     (vendor/symfony/http-kernel/HttpKernel.php:76)
  at Symfony\Component\HttpKernel\HttpKernel->handle()
     (vendor/symfony/http-kernel/Kernel.php:197)
  at Symfony\Component\HttpKernel\Kernel->handle()
     (public/index.php:42)                
@qzminski
Copy link
Member

qzminski commented Oct 4, 2024

This is because of the #263 pull request. I have reverted the changes in 4.0.9.

@qzminski qzminski closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants