Replace use of iterationIsComplete with const.

codeforamerica · Apr 24, 2024 · e10bd74 · e10bd74
1 parent 4309838
commit e10bd74
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/org/mdbenefits/app/preparers/HouseholdDetailsPreparer.java b/src/main/java/org/mdbenefits/app/preparers/HouseholdDetailsPreparer.java
@@ -29,7 +29,7 @@ public Map<String, SubmissionField> prepareSubmissionFields(Submission submissio
         if (household != null) {
             int iteration = 1;  // start at one!
             for (Map<String, Object> householdMember : household) {
-                boolean iterationIsComplete = (boolean) householdMember.get("iterationIsComplete");
+                boolean iterationIsComplete = (boolean) householdMember.get(Submission.ITERATION_IS_COMPLETE_KEY);
                 if (!iterationIsComplete) {
                     log.info(
                             "PDF Household Preparer: Submission {}: found incomplete household member iteration ({}), skipping...",

diff --git a/src/main/java/org/mdbenefits/app/preparers/IncomeDetailsPreparer.java b/src/main/java/org/mdbenefits/app/preparers/IncomeDetailsPreparer.java
@@ -48,7 +48,7 @@ private Map<String, SubmissionField> prepareIncome(Submission submission) {
         if (income != null) {
             int i = 1;
             for (Map<String, Object> incomeDetails : income) {
-                boolean iterationIsComplete = (boolean) incomeDetails.get("iterationIsComplete");
+                boolean iterationIsComplete = (boolean) incomeDetails.get(Submission.ITERATION_IS_COMPLETE_KEY);
                 if (!iterationIsComplete) {
                     log.info("PDF Income Preparer: Submission {}: found incomplete income iteration ({}), skipping it...",
                             submission.getId(), incomeDetails.get("uuid"));

diff --git a/src/test/java/org/mdbenefits/app/data/SubmissionTestBuilder.java b/src/test/java/org/mdbenefits/app/data/SubmissionTestBuilder.java
@@ -105,7 +105,7 @@ public SubmissionTestBuilder withHouseholdMemberApplying(
         member.put("householdMemberHasDisability", isDisabled);
         member.put("householdMemberRace[]", raceInfo);
         member.put("householdMemberEthnicity", ethnicity);
-        member.put("iterationIsComplete", true);
+        member.put(Submission.ITERATION_IS_COMPLETE_KEY, true);
 
         household.add(member);
 
@@ -155,7 +155,7 @@ public SubmissionTestBuilder withJob(String employeeName, String employerName, S
         job.put("employerName", employerName);
         job.put("payPeriodAmount", amount);
         job.put("payPeriod", freq);
-        job.put("iterationIsComplete", true);
+        job.put(Submission.ITERATION_IS_COMPLETE_KEY, true);
 
         income.add(job);
         submission.getInputData().put("income", income);