Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ohep heat and electric page per design changes. #282

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

bseeger
Copy link
Contributor

@bseeger bseeger commented Jun 11, 2024

@bseeger bseeger requested a review from spokenbird June 11, 2024 18:04
@@ -24,15 +24,15 @@
inputName='householdMemberJobAdd',
content=~{::householdMembers})}">
<th:block th:ref="householdMembers">
<th:block
th:replace="~{fragments/inputs/radio :: radio(inputName=${inputName},value='you', label=${inputData.firstName + ' ' + inputData.lastName + ' ' + #messages.msg('general.you')})}"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to go but I was curious why this value is you where the other values are the persons name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I left this part alone so I didn't have to update the pdf logic, as that looks for "you" explicitly.

@bseeger bseeger merged commit 1147eb1 into main Jun 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants