-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sign and Submit screens #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrajmohan
force-pushed
the
sign-and-submit-186915277
branch
4 times, most recently
from
February 4, 2024 16:18
1e7f259
to
ea81d85
Compare
vrajmohan
changed the title
Rename legalStuff to rightsAndResponsibilities
Update Sign and Submit screens
Feb 4, 2024
vrajmohan
force-pushed
the
sign-and-submit-186915277
branch
2 times, most recently
from
February 6, 2024 02:04
6707e1e
to
4dee366
Compare
bseeger
reviewed
Feb 6, 2024
src/main/java/org/mdbenefits/app/submission/actions/SetDefaultSensitiveConvictionAnswers.java
Show resolved
Hide resolved
bseeger
reviewed
Feb 6, 2024
src/main/java/org/mdbenefits/app/preparers/ApplicantDetailsPreparer.java
Outdated
Show resolved
Hide resolved
bseeger
reviewed
Feb 6, 2024
src/main/java/org/mdbenefits/app/submission/actions/SetDefaultSensitiveConvictionAnswers.java
Show resolved
Hide resolved
vrajmohan
force-pushed
the
sign-and-submit-186915277
branch
4 times, most recently
from
February 7, 2024 19:15
42bb91b
to
a9a5fcb
Compare
We are doing this to leverage FFB functionality for filling a single PDF. We will split the PDFs when transmitting them to the county and/or applicant.
1. Test that checkboxes for sensitive questions are set to "true" 2. Test that TCA conditions are shown only if TCA program is selected
Also, move the constant enumerating the questions to a more central place (from review feedback)
vrajmohan
force-pushed
the
sign-and-submit-186915277
branch
from
February 7, 2024 19:16
a9a5fcb
to
104167b
Compare
bseeger
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.