Implement Need and Program Pages #37

analoo · 2024-02-06T20:48:10Z

Implements Need and Program Pages:

To test:

Select A Need (if you select either of the top two options, the next window will show both options with the need you selected prechecked).
Go Back - Select all needs (except not sure) and confirm that in the next page, 4 options appear that are all checked.
Go back. Select "Not Sure". Notice it act's as a "None of the Above". Go to the next page and note that all options are listed but none are checked.

Play around with moving forward to the signpost, and then back: Does the behavior make sense to you?

Once you feel good about the need, check that the pdf form is properly filled out:
If you select SNAP, the snap option on the first page will be checked.
If you select something aside from SNAP, Cash Assistance will be checked.

src/main/java/org/mdbenefits/app/data/enums/HelpNeededType.java

src/main/resources/flows-config.yaml

analoo · 2024-02-06T20:50:21Z

src/main/resources/templates/mdBenefitsFlow/choosePrograms.html

              <th:block th:replace="~{fragments/inputs/checkboxFieldset ::
                  checkboxFieldset(inputName='programs',
-                  label=#{choose-programs.check-all-that-apply},
+                  ariaLabel=#{choose-programs.header},


@bseeger - do we have a best practice around what to include in the ariaLabel?

no, I was wondering that as well. Might be worth checking in with Devon about this.

It should be the HTML ID of the HTML element you want to label the input. It's meant for screens where there is only one input, and the screens H1 header is technically the label for that input. In most cases the value you want here will be 'header' since that's the ID assigned to headers in the FFB. You can just use the string 'header' in this case, but it shouldn't be a message property.

src/main/java/org/mdbenefits/app/submission/actions/PreCheckPrograms.java

src/test/java/org/mdbenefits/app/pdf/PdfServiceTest.java

src/main/java/org/mdbenefits/app/data/enums/HelpNeededType.java

src/main/resources/templates/mdBenefitsFlow/selectHelpNeeded.html

src/main/java/org/mdbenefits/app/data/enums/HelpNeededType.java

src/main/java/org/mdbenefits/app/submission/actions/PreCheckPrograms.java

src/main/java/org/mdbenefits/app/data/enums/HelpNeededType.java

src/main/java/org/mdbenefits/app/submission/actions/PreCheckPrograms.java

src/main/java/org/mdbenefits/app/preparers/ApplicantNeedsPreparer.java

src/main/java/org/mdbenefits/app/submission/actions/PreCheckPrograms.java

src/main/java/org/mdbenefits/app/utils/ApplicationUtilities.java

src/main/resources/templates/mdBenefitsFlow/choosePrograms.html

src/test/java/org/mdbenefits/app/journeys/MdBenefitsFlowJourneyTest.java

bseeger · 2024-02-09T22:51:23Z

@analoo, this looks really great and runs well! I just have some minor comments.

src/main/java/org/mdbenefits/app/data/enums/HelpNeededType.java

bseeger · 2024-02-13T14:47:22Z

src/main/java/org/mdbenefits/app/utils/ApplicationUtilities.java

+
+public class ApplicationUtilities {
+        public static Set<String> flattenHouseholdNeedsPrograms(ArrayList<String> needTypes) {
+                List<List<String>> relevantPrograms = new ArrayList<>();


The indents are off in this file -- 8 instead of 4.

bseeger · 2024-02-13T15:24:01Z

src/test/java/org/mdbenefits/app/journeys/MdBenefitsFlowJourneyTest.java

-        assertThat(testPage.hasErrorText(message("error.missing-general")));
+        assert(testPage.hasErrorText(message("error.missing-general")));
+
+        testPage.clickElementById("helpNeeded-CHILDREN");


I think you can take this line out -- or comment that it does nothing, as the checking none__checkbox will cause it to get unchecked. And maybe that's part of the test as well?

I added a comment since I believe that this is actually an important part of the test since none__checkbox unsets the other checkboxes and behaves differently in the programs pages.

1.Add before save action that presets a few of the programs based on the need selected 2.Add an additional parameter to differentiate between relevant programs and precheckedprograms 3.Write needsCashAssistance and needsSnap to PDF

bseeger · 2024-02-16T15:46:48Z

src/main/resources/messages.properties

@@ -246,6 +246,7 @@ help-needed.food=Help with food
 help-needed.children=Help with money for children


It won't let me mark the right spot, so I'll put this here. If this PR includes the help needed page, then the message for help-needed.subheader needs to be updated as it no longer matches the design.

Same for the "Help with children" - but I wonder if your message is more up to date based on conversations?

bseeger · 2024-02-16T15:53:09Z

src/main/resources/messages.properties

@@ -266,6 +267,9 @@ choose-programs.ohep.desc=<br>Helps with heating, electric and gas bills. Maryla
 choose-programs.tdap=Temporary Disability Assistance Program (TDAP)
 choose-programs.tdap.short-desc=Get help for a disability
 choose-programs.tdap.desc=<br>Gives cash to people who are low-income and living with short-term disability or who are waiting for federal disability help. People with children who are dependents cannot get this benefit.
+choose-programs.rca=Refugee Transitional Cash Assistance (RTCA or RCA)


Note that it looks like the copy for SNAP and TCA has changed in the designs.

The TDAP needs a line break in on spot to match design.

bseeger

This works as described. There are a few copy changes - feel free to merge once you make those.

Nice work - the change to the pdf is nice!

analoo commented Feb 6, 2024

View reviewed changes

src/main/java/org/mdbenefits/app/data/enums/HelpNeededType.java Outdated Show resolved Hide resolved

analoo commented Feb 6, 2024

View reviewed changes

src/main/resources/flows-config.yaml Show resolved Hide resolved

analoo commented Feb 6, 2024

View reviewed changes

src/main/java/org/mdbenefits/app/submission/actions/PreCheckPrograms.java Show resolved Hide resolved

analoo commented Feb 7, 2024

View reviewed changes

src/test/java/org/mdbenefits/app/pdf/PdfServiceTest.java Outdated Show resolved Hide resolved

analoo force-pushed the select-programs-flow branch from 7dd5976 to e77d56a Compare February 7, 2024 20:28

analoo commented Feb 8, 2024

View reviewed changes

src/main/java/org/mdbenefits/app/data/enums/HelpNeededType.java Outdated Show resolved Hide resolved

analoo commented Feb 8, 2024

View reviewed changes

src/main/resources/templates/mdBenefitsFlow/selectHelpNeeded.html Outdated Show resolved Hide resolved

analoo commented Feb 8, 2024

View reviewed changes

src/main/java/org/mdbenefits/app/data/enums/HelpNeededType.java Show resolved Hide resolved

analoo commented Feb 8, 2024

View reviewed changes

src/main/java/org/mdbenefits/app/submission/actions/PreCheckPrograms.java Outdated Show resolved Hide resolved

analoo force-pushed the select-programs-flow branch from e77d56a to 9203402 Compare February 9, 2024 02:37

analoo commented Feb 9, 2024

View reviewed changes

src/main/java/org/mdbenefits/app/data/enums/HelpNeededType.java Show resolved Hide resolved

analoo changed the title ~~WIP"~~ Implements Need and Program Pages Feb 9, 2024

analoo marked this pull request as ready for review February 9, 2024 02:41

bseeger self-requested a review February 9, 2024 20:19

analoo requested review from vrajmohan and spokenbird February 9, 2024 22:11