Revamp citizenship pages #39
Conversation
bseeger
force-pushed
the
add_citizenship_pages_186922240
branch
from
d25214d to
03e89a5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/org/mdbenefits/app/submission/actions/MoveDataIntoSubflowData.java
Fixed
Show fixed
Hide fixed
bseeger
force-pushed
the
add_citizenship_pages_186922240
branch
from
ba9a1ab to
ed3c356
Compare
| privacy.how-we-use.title=How we use your information | ||
| privacy.how-we-use.content.p1=We use your information for our business purposes and legitimate interests such as: | ||
| privacy.how-we-use.content.li1=To help you obtain and keep benefits in Louisiana, including: | ||
| privacy.how-we-use.content.li1.sub1=To complete forms required for the use of the Services | ||
| privacy.how-we-use.content.li1.sub2=To submit your documents and personal information to the Louisiana Department of Children and Family Services | ||
| privacy.how-we-use.content.li1.sub3=To access an account linked to your case in the Louisiana Department of Children and Family Services' online system | ||
| privacy.how-we-use.content.li1.sub4=To send you messages related to your benefits application, updates, and renewals | ||
|
|
There was a problem hiding this comment.
I turned on auto formatting (using the google stylesheet) and it causes this change. Should I reverse this or do we really care?
|
This ticket got put on hold, but we should still get these changes in until other decisions are made. |
| * it belongs with. | ||
| */ | ||
| @Slf4j | ||
| public abstract class MoveDataIntoSubflowData implements Action { |
There was a problem hiding this comment.
I created this to aid in moving data around. The intent is that someone can create a child Action from this and indicate the fields they are moving things to/from.
There was a problem hiding this comment.
This will handle those wildcard fields we want to tuck into household.
| // The previous field (citizenshipStatus) is used as a wildcard to help populate | ||
| // this field below, which is put in the "household[]" members data and not left as | ||
| // a top-level field in the json. | ||
| private String householdMemberCitizenshipStatus; |
There was a problem hiding this comment.
These variables will change some if they revamp the pages. I wouldn't worry about these too much.
| @@ -368,6 +382,9 @@ public class MdBenefitsFlow extends FlowInputs { | |||
|
|
|||
| private String digitalAssisterFeedbackDetail; | |||
|
|
|||
| @NotBlank(message = "{error.missiong-general}") | |||
| private String isApplicantApplying; | |||
|
|
|||
There was a problem hiding this comment.
This is not in a page yet, but will be added at some point.
| public void run(Submission submission) { | ||
| moveDataToSubflowData(submission, "household", "citizenshipStatus", "householdMemberCitizenshipStatus"); | ||
| } | ||
| } |
There was a problem hiding this comment.
If they move the citizen status select boxes to inside of the flow, we can take this action out.
| th:value="${value}" | ||
| th:selected="${selectValue != null ? selectValue.equals(value) : fieldData.getOrDefault(inputName, '').equals(value)}" | ||
| th:text="${optionText}"></option> | ||
| </th:block> |
There was a problem hiding this comment.
I overrode the SelectOption so I could set the value based on something that wasn't in the inputData. This allowed me to preset "Not Applying" on the citizen selection page.
src/main/java/org/mdbenefits/app/data/enums/CitizenStatusTypes.java
Outdated
Show resolved
Hide resolved
src/test/java/org/mdbenefits/app/journeys/MdBenefitsFlowJourneyTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mdbenefits/app/submission/actions/MoveDataIntoSubflowData.java
Outdated
Show resolved
Hide resolved
bseeger
force-pushed
the
add_citizenship_pages_186922240
branch
from
eb8efcc to
8864bc3
Compare
src/test/java/org/mdbenefits/app/data/SubmissionTestBuilder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/mdbenefits/app/journeys/MdBenefitsFlowJourneyTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/mdbenefits/app/journeys/MdBenefitsFlowJourneyTest.java
Outdated
Show resolved
Hide resolved
This will add an enum for CitizenStatusTypes. This also updates tests associated with citizenship.
Adds tests for this as well.
bseeger
force-pushed
the
add_citizenship_pages_186922240
branch
from
8864bc3 to
28b574d
Compare
This will add an enum for CitizenStatusTypes.
This also updates tests associated with citizenship.