Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProConnect button #296

Closed
enguerranws opened this issue Sep 5, 2024 · 1 comment · Fixed by #297
Closed

Add ProConnect button #296

enguerranws opened this issue Sep 5, 2024 · 1 comment · Fixed by #297
Assignees
Labels
enhancement New feature or request

Comments

@enguerranws
Copy link
Collaborator

Right now, we handle FranceConnect, AgentConnect, MonComptePro. In the next weeks, ProConnect is coming (not sure how if it's the new name of AgentConnect or some merge of AgentConnect and MonComptePro), so we should add a way to provide a button in this lib.

Here are the spec: https://github.com/numerique-gouv/agentconnect-documentation/blob/fcdb49688a04fac68940dfec44bc248f95268467/doc_fs/bouton_proconnect.md

tldr: it's the FranceConnect button, but its text is ProConnect.

I think I'll just duplicate FranceConnectButton component and change the text as a first version.

@enguerranws enguerranws added the enhancement New feature or request label Sep 5, 2024
@enguerranws enguerranws self-assigned this Sep 5, 2024
@garronej
Copy link
Collaborator

garronej commented Sep 5, 2024

Thank you for tackling this!

I think I'll just duplicate FranceConnectButton component and change the text as a first version.

Sure! That seems like the good approach.

@enguerranws enguerranws linked a pull request Sep 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@enguerranws @garronej and others