Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajoute nativeImgProps pour les Card #294

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

totakoko
Copy link
Contributor

@totakoko totakoko commented Sep 4, 2024

J'ai dû recréer une PR pour voir un historique OK suite à la PR #285.

Comme conseillé dans la PR, j'introduis nativeImgProps qui est transmis à l'image des Card. (et donc le fameux loading="lazy" qui m'intéresse)

src/Card.tsx Outdated Show resolved Hide resolved
@garronej
Copy link
Collaborator

garronej commented Sep 4, 2024

Merci!

Co-authored-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
Signed-off-by: Maxime Dréau <totakoko@users.noreply.github.com>
@totakoko
Copy link
Contributor Author

totakoko commented Sep 4, 2024

J'ai accepté ta suggestion @garronej

@totakoko
Copy link
Contributor Author

totakoko commented Sep 4, 2024

Bon j'ai corrigé le formatting, cassé avec la suggestion github 😅

@garronej
Copy link
Collaborator

garronej commented Sep 4, 2024

merci!

@garronej garronej merged commit b06fcd6 into codegouvfr:main Sep 4, 2024
1 check passed
garronej added a commit that referenced this pull request Sep 4, 2024
Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants