refactor: fix PHPStan errors

codeigniter4 · Oct 18, 2023 · 03290ab · 03290ab
1 parent 8003927
commit 03290ab
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -2058,7 +2058,7 @@
 ];
 $ignoreErrors[] = [
 	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
-	'count' => 2,
+	'count' => 1,
 	'path' => __DIR__ . '/system/Filters/Filters.php',
 ];
 $ignoreErrors[] = [

diff --git a/system/Filters/Filters.php b/system/Filters/Filters.php
@@ -166,6 +166,7 @@ public function setResponse(ResponseInterface $response)
      * uri and position.
      *
      * @param string $uri URI path relative to baseURL
+     * @phpstan-param 'before'|'after' $position
      *
      * @return RequestInterface|ResponseInterface|string|null
      *
@@ -188,11 +189,8 @@ public function run(string $uri, string $position = 'before')
             return $result;
         }
 
-        if ($position === 'after') {
-            $result = $this->runAfter($this->filtersClass[$position]);
-        }
-
-        return $result;
+        // After
+        return $this->runAfter($this->filtersClass[$position]);
     }
 
     /**
@@ -266,6 +264,8 @@ private function runAfter(array $filterClasses): ResponseInterface
      *
      * @return RequestInterface|ResponseInterface|string|null
      *
+     * @phpstan-param 'before'|'after' $position
+     *
      * @throws FilterException
      */
     public function runRequired(string $position = 'before')