refactor: use str_contains() over strpos on Forge

codeigniter4 · Dec 27, 2024 · 10f3c7e · 10f3c7e
1 parent a2c6db0
commit 10f3c7e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/system/Database/MySQLi/Forge.php b/system/Database/MySQLi/Forge.php
@@ -116,11 +116,11 @@ protected function _createTableAttributes(array $attributes): string
             }
         }
 
-        if ($this->db->charset !== '' && in_array(strpos($sql, 'CHARACTER SET'), [0, false], true) && in_array(strpos($sql, 'CHARSET'), [0, false], true)) {
+        if ($this->db->charset !== '' && ! str_contains($sql, 'CHARACTER SET') && ! str_contains($sql, 'CHARSET')) {
             $sql .= ' DEFAULT CHARACTER SET = ' . $this->db->escapeString($this->db->charset);
         }
 
-        if ($this->db->DBCollat !== '' && in_array(strpos($sql, 'COLLATE'), [0, false], true)) {
+        if ($this->db->DBCollat !== '' && ! str_contains($sql, 'COLLATE')) {
             $sql .= ' COLLATE = ' . $this->db->escapeString($this->db->DBCollat);
         }