fix failing tests for mysqli - enable strict mode

codeigniter4 · Jan 2, 2025 · 20a2e91 · 20a2e91
1 parent bf91cad
commit 20a2e91
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 5 deletions.
diff --git a/tests/system/Database/Live/InsertTest.php b/tests/system/Database/Live/InsertTest.php
@@ -102,7 +102,17 @@ public function testInsertBatchFailed(): void
             ],
         ];
 
-        $this->db->table('job')->insertBatch($data);
+        $db = $this->db;
+
+        if ($this->db->DBDriver === 'MySQLi') {
+            // strict mode is required for MySQLi to throw an exception here
+            $config                   = config('Database');
+            $config->tests['strictOn'] = true;
+
+            $db = Database::connect($config->tests);
+        }
+
+        $db->table('job')->insertBatch($data);
     }
 
     public function testReplaceWithNoMatchingData(): void

diff --git a/tests/system/Database/Live/TransactionTest.php b/tests/system/Database/Live/TransactionTest.php
@@ -254,12 +254,24 @@ public function testTransInsertBatchFailed(): void
             ],
         ];
 
-        $this->db->transStrict(false)->transBegin();
-        $this->db->table('job')->insertBatch($data);
+        $db = $this->db;
 
-        $this->assertFalse($this->db->transStatus());
+        if ($this->db->DBDriver === 'MySQLi') {
+            // strict mode is required for MySQLi to throw an exception here
+            $config                   = config('Database');
+            $config->tests['strictOn'] = true;
 
-        $this->db->transComplete();
+            $db = Database::connect($config->tests);
+        }
+
+        $db->transStrict(false)->transBegin();
+        $db->table('job')->insertBatch($data);
+
+        $this->assertFalse($db->transStatus());
+
+        $db->transComplete();
+
+        $db->transStrict();
 
         $this->dontSeeInDatabase('job', ['name' => 'Grocery Sales']);
     }