Merge pull request #8086 from kenjis/remove-deprecated-commands

refactor: remove deprecated spark commands
codeigniter4 · Oct 24, 2023 · 29b8a9b · 29b8a9b
2 parents 3f30502 + 5298f2a
commit 29b8a9b
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 243 deletions.
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -651,41 +651,6 @@
 	'count' => 2,
 	'path' => __DIR__ . '/system/Commands/Generators/SeederGenerator.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
-	'count' => 2,
-	'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Commands\\\\Generators\\\\SessionMigrationGenerator\\:\\:generateClass\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Commands\\\\Generators\\\\SessionMigrationGenerator\\:\\:generateView\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Only booleans are allowed in &&, mixed given on the left side\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Only booleans are allowed in &&, mixed given on the right side\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Only booleans are allowed in a negated boolean, mixed given\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Short ternary operator is not allowed\\. Use null coalesce operator if applicable or consider using long ternary\\.$#',
-	'count' => 2,
-	'path' => __DIR__ . '/system/Commands/Generators/SessionMigrationGenerator.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
 	'count' => 2,

diff --git a/system/Commands/Generators/MigrateCreate.php b/system/Commands/Generators/MigrateCreate.php
diff --git a/system/Commands/Generators/SessionMigrationGenerator.php b/system/Commands/Generators/SessionMigrationGenerator.php
diff --git a/tests/system/CLI/ConsoleTest.php b/tests/system/CLI/ConsoleTest.php
@@ -90,7 +90,7 @@ public function testBadCommand(): void
 
     public function testHelpCommandDetails(): void
     {
-        $this->initCLI('help', 'session:migration');
+        $this->initCLI('help', 'make:migration');
 
         $console = new Console();
         $console->run();

diff --git a/user_guide_src/source/changelogs/v4.5.0.rst b/user_guide_src/source/changelogs/v4.5.0.rst
@@ -127,6 +127,12 @@ Test
 - ``FeatureResponse``
 - ``FeatureTestCase``
 
+Spark Commands
+--------------
+
+- ``migrate:create``
+- ``session:migration``
+
 Others
 ------
 

diff --git a/user_guide_src/source/cli/cli_generators.rst b/user_guide_src/source/cli/cli_generators.rst
@@ -36,10 +36,6 @@ where ``<generator_command>`` will be replaced with the command to check.
     namespace defined in your ``$psr4`` array in ``Config\Autoload`` or defined in your composer autoload
     file. Otherwise, code generation will be interrupted.
 
-.. important:: Since v4.0.5, use of ``migrate:create`` to create migration files has been deprecated. It will be removed in
-    future releases. Please use ``make:migration`` as replacement. Also, please use ``make:migration --session``
-    to use instead of the deprecated ``session:migration``.
-
 *******************
 Built-in Generators
 *******************