fix: update does not work when using custom entity with toRawArray()

codeigniter4 · Nov 29, 2023 · 2ecff64 · 2ecff64
1 parent 93e9c6b
commit 2ecff64
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/system/BaseModel.php b/system/BaseModel.php
@@ -1698,6 +1698,7 @@ protected function objectToArray($data, bool $onlyChanged = true, bool $recursiv
      */
     protected function objectToRawArray($data, bool $onlyChanged = true, bool $recursive = false): ?array
     {
+        // @TODO Should add an interface for this?
         if (method_exists($data, 'toRawArray')) {
             $properties = $data->toRawArray($onlyChanged, $recursive);
         } else {

diff --git a/system/Model.php b/system/Model.php
@@ -798,7 +798,11 @@ protected function objectToRawArray($data, bool $onlyChanged = true, bool $recur
     {
         $properties = parent::objectToRawArray($data, $onlyChanged);
 
-        $primaryKey = null;
+        if ($onlyChanged === false) {
+            return $properties;
+        }
+
+        $primaryKey = $data->{$this->primaryKey} ?? null;
 
         if ($data instanceof Entity) {
             $cast = $data->cast();
@@ -814,12 +818,11 @@ protected function objectToRawArray($data, bool $onlyChanged = true, bool $recur
 
         // Always grab the primary key otherwise updates will fail.
         if (
-            // @TODO Should use `$data instanceof Entity`.
+            // @TODO Should add an interface for this?
             method_exists($data, 'toRawArray')
             && (
                 ! empty($properties)
                 && ! empty($this->primaryKey)
-                && ! in_array($this->primaryKey, $properties, true)
                 && ! empty($primaryKey)
             )
         ) {