Skip to content

Commit

Permalink
requested updates
Browse files Browse the repository at this point in the history
  • Loading branch information
colethorsen committed Mar 22, 2024
1 parent 5a32fb6 commit 557e2b4
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 9 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
* fix: typo in pager default_simple by @jasonliang-dev in https://github.com/codeigniter4/CodeIgniter4/pull/8407
* refactor: improve Forge variable names by @kenjis in https://github.com/codeigniter4/CodeIgniter4/pull/8434


## [v4.4.4](https://github.com/codeigniter4/CodeIgniter4/tree/v4.4.4) (2023-12-28)
[Full Changelog](https://github.com/codeigniter4/CodeIgniter4/compare/v4.4.3...v4.4.4)

Expand Down
8 changes: 4 additions & 4 deletions system/Database/BaseResult.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace CodeIgniter\Database;

use CodeIgniter\Entity\Entity;
use CodeIgniter\Entity\EntityInterface;
use stdClass;

/**
Expand Down Expand Up @@ -159,7 +159,7 @@ public function getCustomResultObject(string $className)
$this->customResultObject[$className] = [];

while ($row = $this->fetchObject($className)) {
if (! is_subclass_of($row, Entity::class) && method_exists($row, 'syncOriginal')) {
if (! is_subclass_of($row, EntityInterface::class) && method_exists($row, 'syncOriginal')) {
$row->syncOriginal();
}

Expand Down Expand Up @@ -240,7 +240,7 @@ public function getResultObject(): array
}

while ($row = $this->fetchObject()) {
if (! is_subclass_of($row, Entity::class) && method_exists($row, 'syncOriginal')) {
if (! is_subclass_of($row, EntityInterface::class) && method_exists($row, 'syncOriginal')) {
$row->syncOriginal();
}

Expand Down Expand Up @@ -539,7 +539,7 @@ abstract protected function fetchAssoc();
*
* Overridden by child classes.
*
* @return Entity|false|object|stdClass
* @return EntityInterface|false|object|stdClass
*/
abstract protected function fetchObject(string $className = 'stdClass');
}
2 changes: 1 addition & 1 deletion system/Database/MySQLi/Result.php
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ protected function fetchAssoc()
*
* Overridden by child classes.
*
* @return Entity|false|object|stdClass
* @return EntityInterface|false|object|stdClass
*/
protected function fetchObject(string $className = 'stdClass')
{
Expand Down
2 changes: 1 addition & 1 deletion system/Database/OCI8/Result.php
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ protected function fetchAssoc()
*
* Overridden by child classes.
*
* @return Entity|false|object|stdClass
* @return EntityInterface|false|object|stdClass
*/
protected function fetchObject(string $className = 'stdClass')
{
Expand Down
2 changes: 1 addition & 1 deletion system/Database/Postgre/Result.php
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ protected function fetchAssoc()
*
* Overridden by child classes.
*
* @return Entity|false|object|stdClass
* @return EntityInterface|false|object|stdClass
*/
protected function fetchObject(string $className = 'stdClass')
{
Expand Down
2 changes: 1 addition & 1 deletion system/Database/SQLSRV/Result.php
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ protected function fetchAssoc()
/**
* Returns the result set as an object.
*
* @return Entity|false|object|stdClass
* @return EntityInterface|false|object|stdClass
*/
protected function fetchObject(string $className = 'stdClass')
{
Expand Down

0 comments on commit 557e2b4

Please sign in to comment.