Merge pull request #8011 from kenjis/fix-200-OK-to-404

fix: CI returns "200 OK" when PageNotFound
codeigniter4 · Oct 8, 2023 · 56ed7b2 · 56ed7b2
2 parents 83b64b4 + 33708a8
commit 56ed7b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/system/CodeIgniter.php b/system/CodeIgniter.php
@@ -979,8 +979,7 @@ protected function display404errors(PageNotFoundException $e)
         // Display 404 Errors
         $this->response->setStatusCode($e->getCode());
 
-        echo $this->outputBufferingEnd();
-        flush();
+        $this->outputBufferingEnd();
 
         // Throws new PageNotFoundException and remove exception message on production.
         throw PageNotFoundException::forPageNotFound(

diff --git a/user_guide_src/source/changelogs/v4.4.2.rst b/user_guide_src/source/changelogs/v4.4.2.rst
@@ -32,6 +32,9 @@ Deprecations
 Bugs Fixed
 **********
 
+- **CodeIgniter:** Fixed a bug that returned "200 OK" response status code when
+  Page Not Found.
+
 See the repo's
 `CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_
 for a complete list of bugs fixed.