refactor: Fix phpstan always true (#9367)

codeigniter4 · Jan 10, 2025 · 708fb6d · 708fb6d
1 parent 42a00ff
commit 708fb6d
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/system/Helpers/filesystem_helper.php b/system/Helpers/filesystem_helper.php
@@ -96,7 +96,7 @@ function directory_mirror(string $originDir, string $targetDir, bool $overwrite
                 if (! is_dir($target)) {
                     mkdir($target, 0755);
                 }
-            } elseif (! is_file($target) || ($overwrite && is_file($target))) {
+            } elseif ($overwrite || ! is_file($target)) {
                 copy($origin, $target);
             }
         }

diff --git a/utils/phpstan-baseline/booleanAnd.rightAlwaysTrue.neon b/utils/phpstan-baseline/booleanAnd.rightAlwaysTrue.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -1,7 +1,6 @@
 includes:
     - argument.type.neon
     - assign.propertyType.neon
-    - booleanAnd.rightAlwaysTrue.neon
     - codeigniter.cacheHandlerInstance.neon
     - codeigniter.configArgumentInstanceof.neon
     - codeigniter.frameworkExceptionInstance.neon