Merge pull request #8656 from kenjis/add-comments-to-PDO_PGSQL-DSN

docs: add commnets on Postgre::convertDSN()
codeigniter4 · Mar 28, 2024 · 87652c9 · 87652c9
2 parents 2a63810 + 2636541
commit 87652c9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/system/Database/Postgre/Connection.php b/system/Database/Postgre/Connection.php
@@ -65,6 +65,9 @@ public function connect(bool $persistent = false)
         }
 
         // Convert DSN string
+        // @TODO This format is for PDO_PGSQL.
+        //      https://www.php.net/manual/en/ref.pdo-pgsql.connection.php
+        //      Should deprecate?
         if (mb_strpos($this->DSN, 'pgsql:') === 0) {
             $this->convertDSN();
         }

diff --git a/tests/system/Database/ConfigTest.php b/tests/system/Database/ConfigTest.php
@@ -198,6 +198,9 @@ public function testConnectionGroupWithDSNPostgreNative(): void
      */
     public function testConvertDSN(string $input, string $expected): void
     {
+        // @TODO This format is for PDO_PGSQL.
+        //      https://www.php.net/manual/en/ref.pdo-pgsql.connection.php
+        //      Should deprecate?
         $this->dsnGroupPostgreNative['DSN'] = $input;
         $conn                               = Config::connect($this->dsnGroupPostgreNative, false);
         $this->assertInstanceOf(BaseConnection::class, $conn);