refactor: Fix phpstan condNotBoolean (#9368)

codeigniter4 · Jan 4, 2025 · db12ec3 · db12ec3
1 parent 91e788a
commit db12ec3
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 10 deletions.
diff --git a/system/CLI/CLI.php b/system/CLI/CLI.php
@@ -289,7 +289,7 @@ public static function promptByKey($text, array $options, $validation = null): s
 
         CLI::isZeroOptions($options);
 
-        if ($line = array_shift($text)) {
+        if (($line = array_shift($text)) !== null) {
             CLI::write($line);
         }
 

diff --git a/utils/phpstan-baseline/if.condNotBoolean.neon b/utils/phpstan-baseline/if.condNotBoolean.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -21,7 +21,6 @@ includes:
     - generator.returnType.neon
     - generator.valueType.neon
     - greaterOrEqual.invalid.neon
-    - if.condNotBoolean.neon
     - isset.offset.neon
     - isset.property.neon
     - method.alreadyNarrowedType.neon