Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PHPStan errors #8034

Merged
merged 2 commits into from
Oct 12, 2023
Merged

fix: PHPStan errors #8034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26809f
chore: update for phpstan-codeigniter v1.4.0
kenjis Oct 12, 2023
65b01f6
fix: incorrect class name
kenjis Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,8 @@ parameters:
booleansInConditions: true
disallowedConstructs: true
matchingInheritedMethodNames: true
ignoreErrors:
- '#^Call to function config with Config\\.+\:\:class is discouraged\.$#'
codeigniter:
additionalConfigNamespaces:
- CodeIgniter\Config\
2 changes: 1 addition & 1 deletion system/Config/Factories.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ public static function getOptions(string $component): array
// Handle Config as a special case to prevent logic loops
? self::$configOptions
// Load values from the best Factory configuration (will include Registrars)
: config(Factory::class)->{$component} ?? [];
: config('Factory')->{$component} ?? [];

// The setOptions() reset the component. So getOptions() may reset
// the component.
Expand Down
Loading