Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve $DBGroup description in Model #8074

Merged
merged 2 commits into from
Oct 25, 2023
Merged

docs: improve $DBGroup description in Model #8074

merged 2 commits into from
Oct 25, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 22, 2023

Description
See #8073

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Oct 22, 2023
MGatner
MGatner approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion

user_guide_src/source/models/model.rst Outdated Show resolved Hide resolved
@kenjis @MGatner
docs: fix by proofreading
c64959e 
Co-authored-by: MGatner <mgatner@icloud.com>
@kenjis kenjis merged commit 7cd5c99 into codeigniter4:develop Oct 25, 2023
@kenjis kenjis deleted the docs-model-DBGroup branch October 25, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @MGatner