add: generate also html coverage reports when running script 'test' #8266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Samuel Asor <8720569+sammyskills@users.noreply.github.com>
When running 'composer test', if XDebug is installed and setup (xdebug.mode = coverage), in addition to the file build/logs/clover.xml, generate also nice html coverage reports in folder build/coverage. PHPunit runs normally if XDebug is missing or it is not set for coverage. View the coverage report at build/coverage/index.html.
|
Why not just add it to the phpunit.xml.dist so locally it can be seen too? |
…l.dist Changed destination folder to build/coverage/html. Inline with framework requirements added setting highLowerBound with value 80
|
Good idea. Thank you. |
|
I'm fine with this change. |
|
Okay. I'm on it. |
docs: improve pagination
… documented the changes
kenjis
reviewed
Nov 29, 2023
Comment on lines
+38
to
+39
| <html outputDirectory="tests/coverage" highLowerBound="80"/> | ||
| <text outputFile="tests/coverage.txt"/> |
There was a problem hiding this comment.
I don't like to put files in tests/ because it is for test code.
Use build/ instead.
kenjis
reviewed
Nov 29, 2023
| @@ -25,14 +25,14 @@ | |||
| class PagerRenderer | |||
| { | |||
| /** | |||
| * First page number. | |||
| * First page number in the set of links to be displayed. | |||
There was a problem hiding this comment.
You seemed to do something wrong with git.
Please get rid of unrelated commits from this PR.
|
I will do another PR. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running 'composer test', if XDebug is installed and setup (xdebug.mode = coverage), in addition to the file build/logs/clover.xml, generate also nice html coverage reports in folder build/coverage.
PHPunit runs normally if XDebug is missing or it is not set for coverage.
View the coverage report at build/coverage/index.html.
Description
Explain what you have changed, and why.
Checklist: