Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Test class Generator #8334

Closed
wants to merge 8 commits into from
Closed

feat: Test class Generator #8334

wants to merge 8 commits into from

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 15, 2023 •
edited
Loading

Description
Supersedes #8333

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis marked this pull request as draft December 15, 2023 08:12
@kenjis kenjis mentioned this pull request Dec 15, 2023
Merged
5 tasks
@lonnieezell
Copy link
Member

I obviously did something wrong trying to push changes up after I pulled this, but we need to make 2 changes, and then I'm good with it.

  1. Change the classNameLang string as per the suggestion
  2. Add test => 'Test class name' to the system/Language/en/CLI.php file.

lonnieezell
lonnieezell reviewed Dec 17, 2023
View reviewed changes
system/Commands/Generators/TestGenerator.php
$this->template = 'test.tpl.php';
$this->namespace = 'Tests';

$this->classNameLang = 'CLI.generator.className.entity';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->classNameLang = 'CLI.generator.className.entity';
$this->classNameLang = 'CLI.generator.className.test';

@lonnieezell
Copy link
Member

@kenjis Are you going to be able to make that small change I mentioned? Or should I update my PR?

@kenjis
Copy link
Member Author

kenjis commented Dec 25, 2023

@lonnieezell Please update your PR.
I think it is better that you finish your PR.

@kenjis kenjis closed this Dec 26, 2023
@kenjis kenjis deleted the make-test-fixed branch December 26, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @lonnieezell