Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add "Error Handling" in "Upgrading from 3.x to 4.x" #8350

Merged
merged 4 commits into from
Dec 25, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 20, 2023

Description
From https://forum.codeigniter.com/showthread.php?tid=88993

  • add "Error Handling" in "Upgrading from 3.x to 4.x"

See

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Dec 20, 2023
Error Handling
==============

- The behavior in CI4 has been slightly changed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance, I don't quite understand it well. Can we make it in tabular form?

Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@kenjis
Copy link
Member Author

kenjis commented Dec 22, 2023

The production setting is error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT & ~E_USER_NOTICE & ~E_USER_DEPRECATED). So if E_WARNING error happens, in CI3 it is logged, but does not stop the framework. But in CI4, it is logged and stops the framework.

After all, this seems okay.
Screenshot 2023-12-22 17 02 30

@kenjis kenjis requested a review from michalsn December 22, 2023 08:11
@kenjis kenjis force-pushed the docs-upgrade_4x-error-handling branch from 597079b to 7e35646 Compare December 22, 2023 08:13
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@kenjis kenjis merged commit f06395c into codeigniter4:develop Dec 25, 2023
2 checks passed
@kenjis kenjis deleted the docs-upgrade_4x-error-handling branch December 25, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants