Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replace to composer.json #8355

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Add replace to composer.json #8355

merged 1 commit into from
Dec 21, 2023

Conversation

paulbalandan
Copy link
Member

Description
This allows when a package requires codeigniter4/framework and this repo is already available, composer will not install codeigniter4/framework.

This fixes CodeIgniter/phpstan-codeigniter@530b659#r135480594

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan requested a review from kenjis December 21, 2023 07:37
kenjis
kenjis approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 9483732 into codeigniter4:develop Dec 21, 2023
58 checks passed
@paulbalandan paulbalandan deleted the replace branch December 21, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @michalsn