Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix spark db:table causes errors with table name including special chars #8696

Closed
wants to merge 4 commits into from
Closed

feat: fix spark db:table causes errors with table name including special chars #8696

wants to merge 4 commits into from

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 1, 2024 •
edited
Loading

Description
Alternative: #8695
Fixes #6765

  • add TableName class
  • fix spark db:table causes errors with table name including special chars

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them enhancement PRs that improve existing functionalities database Issues or pull requests that affect the database layer breaking change Pull requests that may break existing functionalities 4.5 labels Apr 1, 2024
@kenjis kenjis marked this pull request as draft April 1, 2024 05:30
@kenjis kenjis mentioned this pull request Apr 1, 2024
Open
@kenjis kenjis changed the title feat: spark db:table causes errors w/z table name including special chars feat: fix spark db:table causes errors w/z table name including special chars Apr 1, 2024
@kenjis kenjis force-pushed the feat-db-tablename-object branch 3 times, most recently from ecd386e to 3235de8 Compare April 1, 2024 06:31
@kenjis kenjis force-pushed the feat-db-tablename-object branch 2 times, most recently from 16b7b08 to 2c2bd50 Compare April 2, 2024 01:36
@kenjis kenjis force-pushed the feat-db-tablename-object branch from 2c2bd50 to ca67bbd Compare April 2, 2024 02:13
@kenjis kenjis changed the title feat: fix spark db:table causes errors w/z table name including special chars feat: fix spark db:table causes errors with table name including special chars Apr 2, 2024
@github-actions github-actions bot added the stale Pull requests with conflicts label Apr 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2024

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis deleted the branch codeigniter4:4.5 April 7, 2024 04:47
@kenjis kenjis closed this Apr 7, 2024
@kenjis kenjis mentioned this pull request Apr 10, 2024
Merged
5 tasks
@kenjis kenjis deleted the feat-db-tablename-object branch April 26, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4.5 breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer enhancement PRs that improve existing functionalities stale Pull requests with conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kenjis