Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enable AddArrowFunctionReturnTypeRector #9343

Merged
merged 3 commits into from
Dec 28, 2024
Merged

refactor: enable AddArrowFunctionReturnTypeRector #9343

merged 3 commits into from
Dec 28, 2024

Conversation

samsonasik
Copy link
Member

Description

To add return type on Arrow Function.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

paulbalandan
paulbalandan reviewed Dec 28, 2024
View reviewed changes
app/Views/errors/cli/error_exception.php Outdated Show resolved Hide resolved
system/Helpers/form_helper.php Outdated Show resolved Hide resolved
system/Validation/Validation.php Outdated Show resolved Hide resolved
system/Validation/Validation.php Outdated Show resolved Hide resolved
@samsonasik
Copy link
Member Author

@paulbalandan feedback incorporated 👍

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Dec 28, 2024
paulbalandan
paulbalandan approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍🏻

@samsonasik
Copy link
Member Author

Thank you @michalsn @paulbalandan for the review, let's merge 👍

@samsonasik samsonasik merged commit 51e6f6a into codeigniter4:develop Dec 28, 2024
41 checks passed
@samsonasik samsonasik deleted the refactor-add-arrow-function-return branch December 28, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @michalsn @paulbalandan