fix: handle namespaced helper found on Common helper #9354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed and added test case 🎉 /cc @yllumi |
5 tasks
samsonasik
force-pushed
the
fix-namespaced-helper
branch
from
b572509 to
9e698a6
Compare
|
Ready to merge 👍 /cc @neznaika0 |
samsonasik
force-pushed
the
fix-namespaced-helper
branch
from
e907809 to
f551dbd
Compare
michalsn
approved these changes
Dec 30, 2024
|
Thank you @michalsn for the review, let's merge 👍 |
|
@samsonasik Oh... I forgot - we need a changelog entry 😅 |
5 tasks
|
@michalsn sure, here the PR for changelog: |
paulbalandan
added
the
bug
samsonasik
referenced
this pull request
Dec 31, 2024
* refactor: Fix `phpstan` errors related to `Autoloader` * fix: Update @ignore-line * fix: Save `realpath()` as variable * refactor: `phpstan` strict comparison * fix: Restore check helpers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #9350
@yllumi this should handle #9350
Checklist: