New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Fix phpstan if.condNotBoolean #9368

Merged

paulbalandan merged 1 commit into codeigniter4:develop from neznaika0:refactor/phpstan-cond-not-bool

Jan 4, 2025

Contributor

neznaika0 commented Jan 3, 2025

Description
This is a rare case, but there are no tests for wrong $options values ("", null, [] ...). Leaving it?

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide


          refactor: Fix phpstan condNotBoolean

a4c50c3

paulbalandan approved these changes

View reviewed changes

Member

paulbalandan left a comment

I think it's fine as CLI::write will check it anyway, if I'm not mistaken.

paulbalandan added the refactor label

michalsn approved these changes

View reviewed changes

paulbalandan merged commit db12ec3 into codeigniter4:develop

41 checks passed

neznaika0 deleted the refactor/phpstan-cond-not-bool branch

January 4, 2025 10:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels