Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Fix phpstan when delete string key #9369

Merged
merged 1 commit into from
Jan 4, 2025
Merged

refactor: Fix phpstan when delete string key #9369

merged 1 commit into from
Jan 4, 2025

Conversation

neznaika0
Copy link
Contributor

Description
Wrong PHPDoc type $expirations

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Jan 4, 2025
@neznaika0 neznaika0 force-pushed the refactor/phpstan-unset-offset branch from 050011b to a6d9716 Compare January 4, 2025 11:18
@samsonasik samsonasik merged commit 536570b into codeigniter4:develop Jan 4, 2025
41 checks passed
@samsonasik
Copy link
Member

Thank you @neznaika0

@neznaika0 neznaika0 deleted the refactor/phpstan-unset-offset branch January 4, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan left review comments

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neznaika0 @samsonasik @paulbalandan