Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix phpstan function.inner #9377

Merged

Conversation

neznaika0
Copy link
Contributor

Description
Just ignoring it.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Jan 5, 2025
@neznaika0 neznaika0 force-pushed the refactor/phpstan-func-inner branch from 9da5a62 to d4ea344 Compare January 5, 2025 18:37
@neznaika0 neznaika0 closed this Jan 5, 2025
@neznaika0 neznaika0 force-pushed the refactor/phpstan-func-inner branch from d4ea344 to 61741c5 Compare January 5, 2025 18:39
@neznaika0
Copy link
Contributor Author

Oh, what happened? I rebased and down..

@samsonasik samsonasik reopened this Jan 5, 2025
@samsonasik
Copy link
Member

samsonasik commented Jan 5, 2025

do you close the PR? If not, probably github glitch

Let's reopen

@neznaika0
Copy link
Contributor Author

Thanks. Yes, in browser bug.

@paulbalandan paulbalandan merged commit 08540f7 into codeigniter4:develop Jan 6, 2025
40 checks passed
@neznaika0 neznaika0 deleted the refactor/phpstan-func-inner branch January 8, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants