Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use strtolower with str_contains/str_**_with as replacement for stripos #9414

Merged
merged 2 commits into from
Jan 17, 2025
Merged

refactor: Use strtolower with str_contains/str_**_with as replacement for stripos #9414

merged 2 commits into from
Jan 17, 2025
+20 −35

Conversation

paulbalandan
Copy link
Member

Description

  • New in the modernize_strpos fixer. The fixer is not perfect yet so I had to manually fix some conversions (e.g. strtolower('int').
  • Also, I saw there's a wrong condition in the CacheFactoryTest which will never happen.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Jan 17, 2025
@neznaika0
Copy link
Contributor

How creepy it looks with strtolower()

@paulbalandan paulbalandan merged commit 119330c into codeigniter4:develop Jan 17, 2025
41 checks passed
@paulbalandan paulbalandan deleted the modernize-stripos branch January 17, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulbalandan @neznaika0 @michalsn @samsonasik