Added ability to scrape javascript intensive apps #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds compelling. I noticed your change sent includes conversion of single to double quotes and some formatting. It would be easier to review these changes if it were limited only to materially changed lines. While I do not believe the maintainer is approving PRs at this time, in general I'd suggest offering a PR with changes that only include what you're working on. Then consider a second that affects formatting in a more general sense. -- All that said, I'm curious if you have test cases of sites that show article content using JS that fail using the main branch but pass using your change set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library was failing to scrape sites which have javascript code in it so i have added the ability to scrape such websites. So now it will be possible to scrape sites made with Vue, React and other JS intensive frameworks