Make block gap widgets editable

To work around poor iOS behavior on select-all. Issue codemirror/dev#1304
codemirror · Dec 14, 2023 · 7cb7d5b · 7cb7d5b
1 parent fdb12c0
commit 7cb7d5b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/src/blockview.ts b/src/blockview.ts
@@ -205,7 +205,7 @@ export class BlockWidgetView extends ContentView implements BlockView {
       if (this.dom && this.prevWidget) this.prevWidget.destroy(this.dom)
       this.prevWidget = null
       this.setDOM(this.widget.toDOM(view))
-      this.dom!.contentEditable = "false"
+      if (!this.widget.editable) this.dom!.contentEditable = "false"
     }
   }
 

diff --git a/src/decoration.ts b/src/decoration.ts
@@ -152,6 +152,9 @@ export abstract class WidgetType {
   /// @internal
   get isHidden() { return false }
 
+  /// @internal
+  get editable() { return false }
+
   /// This is called when the an instance of the widget is removed
   /// from the editor view.
   destroy(dom: HTMLElement) {}

diff --git a/src/docview.ts b/src/docview.ts
@@ -555,6 +555,8 @@ class BlockGapWidget extends WidgetType {
     return true
   }
 
+  get editable() { return true }
+
   get estimatedHeight() { return this.height }
 }
 

diff --git a/src/inlineview.ts b/src/inlineview.ts
@@ -182,7 +182,7 @@ export class WidgetView extends ContentView {
       if (this.dom && this.prevWidget) this.prevWidget.destroy(this.dom)
       this.prevWidget = null
       this.setDOM(this.widget.toDOM(view))
-      this.dom!.contentEditable = "false"
+      if (!this.widget.editable) this.dom!.contentEditable = "false"
     }
   }