Skip to content

Commit

Permalink
Re-enable EditContext on browsers that support it
Browse files Browse the repository at this point in the history 
FIX: Re-enable `EditContext` use on Chrome 126 and up.
  • Loading branch information
@marijnh
marijnh committed Jun 21, 2024
1 parent f242f4b commit a5ee37d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/domobserver.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export class DOMObserver {
this.flush()
})

if (window.EditContext && (view.constructor as any).EDIT_CONTEXT === true &&
if (window.EditContext && (view.constructor as any).EDIT_CONTEXT !== false &&

This comment has been minimized.

Sign in to view

Copy link
@TrySound

TrySound Aug 8, 2024

This api bugged our app heavily. Seems like still not ready for production.
webstudio-is/webstudio@fd8636c

This comment has been minimized.

Sign in to view

Copy link
@marijnh

marijnh Aug 9, 2024

Author Member

That gives me zero information and is not actionable feedback. Open specific, clear issues if you want me to look at actual problems.
// Chrome <126 doesn't support inverted selections in edit context (#1392)
!(browser.chrome && browser.chrome_version < 126)) {
this.editContext = new EditContextManager(view)
Expand Down

0 comments on commit a5ee37d

Please sign in to comment.