Skip to content
This repository has been archived by the owner on Jan 17, 2021. It is now read-only.

Ctrl-J in extensions view opens up Chrome downloads page instead of VSCode terminal #151

Open
samuela opened this issue Nov 24, 2019 · 7 comments

Comments

@samuela
Copy link

samuela commented Nov 24, 2019

Title really says it all. A lot of the time when I hit Ctrl-J, it ends up opening the Chrome "Downloads" page instead of toggling the VSCode terminal on/off.

@Merith-TK
Copy link
Contributor

Merith-TK commented Nov 24, 2019

Yeah due to the nature of the software, thare are some keybinds that cant be controlled, also i feel as if this is a issue for normal Code-Server as this has to deal with code-server and NOT sshcode

EDIT: the default keymap for opening the terminal is CTRL+SHIFT+~

@samuela
Copy link
Author

samuela commented Nov 25, 2019

Oh, that's right. Ctrl-J is toggles the bottom bar thingy, but not the terminal per se.

@Merith-TK
Copy link
Contributor

Also i cannot reproduce this

@samuela
Copy link
Author

samuela commented Nov 26, 2019

I'm running Chromium 74.0.3729.157 (Official Build) Built on Raspbian , running on Raspbian 10 (32-bit). sshcode installed via go get -u go.coder.com/sshcode.

Maybe it's a Chrome vs Chromium issue? I should also point out that it doesn't occur every time... There are certain scenarios in which Ctrl-J works just as expected and others where it opens up the Downloads page.

@Merith-TK
Copy link
Contributor

Hmm, not really,
I use brave with no issue, but it might be the fact that you are using a Pi?

@samuela
Copy link
Author

samuela commented Nov 26, 2019

Possibly, I'd imagine it has to do with how the browser shim propagates keyboard events but I can't be sure of that.

@Merith-TK
Copy link
Contributor

Merith-TK commented Nov 26, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants