SSH question

[GrimTheReaper]

Why aren't you guys using https://github.com/gliderlabs/ssh or better yet, https://golang.org/x/crypto/ssh?

I feel like it would probably allow for native Windows support, no?

[Merith-TK]

I have been wondering this expact thing My guess? Rsync and ssh flag support

…

On Fri, Dec 27, 2019, 11:20 AM Grim ***@***.***> wrote: Why aren't you guys using https://github.com/gliderlabs/ssh or better yet, golang.org/x/crypto/ssh? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#160>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACPQOXTTQEO7TRTZU7XULCLQ2ZIPDANCNFSM4KAAY6RA> .

[IngCr3at1on]

I was also wondering, but to that end, I don't quite understand the following.

My guess? Rsync and ssh flag support

specifically what "flag support"?

As for rsync I wonder if https://github.com/mutagen-io/mutagen/tree/master/pkg/synchronization/rsync should be considered instead of requiring rsync itself to be installed (might be worth a separate issue to discuss rsync as it's own topic).

[Merith-TK]

Well what if a user wants to pass advanced ssh flags to the server? Like proxy back another port at the same time if they are developing a project that uses web technologies. And for rsync, that looks interesting, if you want to make a PR, feel free.

…

On Mon, Dec 30, 2019, 10:24 AM Nathan Bass ***@***.***> wrote: I was also wondering, but to that end, I don't quite understand the following. My guess? Rsync and ssh flag support specifically what "flag support"? As for rsync I wonder if https://github.com/mutagen-io/mutagen/tree/master/pkg/synchronization/rsync should be considered instead of requiring rsync itself to be installed (might be worth a separate issue to discuss rsync as it's own topic). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#160>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACPQOXQIXOZMQL6ZVVQTLYLQ3I4FNANCNFSM4KAAY6RA> .

[GrimTheReaper]

If they want to open up a port, why not open up another ssh connection, or use some other tool?

[Merith-TK]

Why run three commands instead of one? The logic you have just isn't there, And having ssh flags make it easier to add ssh features as we can just used those flags. Or people can use the flags to do more things than what sshcode has built in.

…

On Tue, Dec 31, 2019, 8:30 AM Grim ***@***.***> wrote: If they want to open up a port, why not open up another ssh connection, or use some other tool? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#160>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACPQOXUFXERRMCM3GBFCHYTQ3NXSTANCNFSM4KAAY6RA> .

[IngCr3at1on]

Interesting difference in perspective; I personally strive for the model of "do one thing well and leave other out of scope functionality up to other applications"; the idea of using sshcode for anything other than starting my code-server and vscode connection never crossed my mind.

Counterpoint; what if all I want is to start code-server and vscode from a minimal environment, first I must install ssh just so os.Exec can call the binary instead of the functionality being compiled into the application itself; this seems more cumbersome than running other entirely not related functions in a separate command.

[Merith-TK]

Hmm... Good counterpoint. Maybe check if ssh binary exists in PATH, if not, then fall back to the ssh library in golang and notify that certain capabilities will not function as intended such as rsync?

…

On Tue, Dec 31, 2019, 9:31 AM Nathan Bass ***@***.***> wrote: Interesting difference in perspective; I personally strive for the model of "do one thing well and leave other out of scope functionality up to other applications"; the idea of using sshcode for anything other than starting my code-server and vscode connection never crossed my mind. Counterpoint; what if *all* I want is to start code-server and vscode from a minimal environment, first I must install ssh just so os.Exec can call the binary instead of the functionality being compiled into the application itself; this seems more cumbersome than running other *entirely not related* functions in a separate command. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#160>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACPQOXWGV3OHYSGVHNZGTZ3Q3N6XVANCNFSM4KAAY6RA> .