Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for feature toggles #429

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Conversation

alexeykazakov
Copy link
Contributor

@alexeykazakov alexeykazakov commented Jun 18, 2024

Description

API for feature toggles/flags.

https://issues.redhat.com/browse/SANDBOX-653

Checks

  1. Did you run make generate target? yes

  2. Did make generate change anything in other projects (host-operator, member-operator)? yes

  3. In case of new CRD, did you do the following? yes

  4. In case other projects are changed, please provides PR links.

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! the comments are very clear and well written 👍

api/v1alpha1/toolchainconfig_types.go Outdated Show resolved Hide resolved
alexeykazakov and others added 3 commits June 19, 2024 10:20
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

api/v1alpha1/toolchainconfig_types.go Show resolved Hide resolved
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Copy link
Contributor

@ranakan19 ranakan19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@alexeykazakov alexeykazakov merged commit a29b6c6 into codeready-toolchain:master Jun 20, 2024
2 checks passed
@alexeykazakov alexeykazakov deleted the osl branch June 20, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants