Add target cluster to social event #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeykazakov
requested review from
MatousJobanek,
xcoulon,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
ranakan19
approved these changes
Aug 15, 2024
rajivnathan
approved these changes
Aug 15, 2024
mfrancisc
reviewed
Aug 16, 2024
Correct. The samecluster field was not used anywhere. Controllers do not use it (so it was ignored). Existing social event CRs didn't have this field set either. So no migration needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
PreferSameCluster, which is not currently used at all, byTargetClusterPart of https://issues.redhat.com/browse/SANDBOX-724