Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused token claim properties from API #957

Merged
merged 21 commits into from
Feb 7, 2024

Conversation

sbryzak
Copy link
Contributor

@sbryzak sbryzak commented Jan 11, 2024

Regenerated from API

Related API PR: codeready-toolchain/api#393

e2e tests: codeready-toolchain/toolchain-e2e#878

@sbryzak
Copy link
Contributor Author

sbryzak commented Feb 1, 2024

/retest

@sbryzak
Copy link
Contributor Author

sbryzak commented Feb 6, 2024

/retest

Copy link

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, sbryzak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,sbryzak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
14.4% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Merging #957 (69b2bea) into master (b52c7c1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
- Coverage   83.66%   83.64%   -0.02%     
==========================================
  Files          55       55              
  Lines        6275     6243      -32     
==========================================
- Hits         5250     5222      -28     
+ Misses        839      836       -3     
+ Partials      186      185       -1     
Files Coverage Δ
controllers/usersignup/usersignup_controller.go 74.62% <100.00%> (-0.82%) ⬇️

... and 1 file with indirect coverage changes

@sbryzak sbryzak merged commit 9724f95 into codeready-toolchain:master Feb 7, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants