KUBESAW-10: Rename the ToolchainCluster controller to ToolchainCluster_cache controller #999
Conversation
…roller Signed-off-by: Feny Mehta <fbm3307@gmail.com>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
fbm3307
changed the title
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
| if err = toolchainclustercache.NewReconciler( | ||
| mgr, | ||
| namespace, | ||
| memberClientTimeout, |
There was a problem hiding this comment.
could you please update also the error message a few lines below:
Line 223 in 297336f
There was a problem hiding this comment.
you mean to add "ToolchainClusterCache" instead of "ToolchainCluster"..?
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
==========================================
+ Coverage 84.84% 84.87% +0.03%
==========================================
Files 55 55
Lines 5066 5066
==========================================
+ Hits 4298 4300 +2
+ Misses 585 583 -2
Partials 183 183 |
This is to Rename the ToolchainCluster controller to ToolchainCluster_cache controller
PRs in other related repos:
Toolchain Common - codeready-toolchain/toolchain-common#378
Member-Operator - codeready-toolchain/member-operator#550
Other repo PRs where the only change is to update the go.mod dependency
Registration-Service - codeready-toolchain/registration-service#418
Toolchain-e2e - codeready-toolchain/toolchain-e2e#932
Sandbox-sre - https://github.com/codeready-toolchain/sandbox-sre/pull/1633