Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set threshold to 1% #483

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Set threshold to 1% #483

merged 3 commits into from
Oct 13, 2023

Conversation

jkopriva
Copy link
Contributor

Set threshold to 1%

@jkopriva
Set threshold to 1%
bbc7afa 
Signed-off-by: Josef Kopriva <jkopriva@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #483 (b52208a) into master (94559a0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   82.29%   82.29%           
=======================================
  Files          28       28           
  Lines        3101     3101           
=======================================
  Hits         2552     2552           
  Misses        419      419           
  Partials      130      130

@jkopriva jkopriva marked this pull request as ready for review October 13, 2023 05:59
@openshift-ci openshift-ci bot requested review from sbryzak and xcoulon October 13, 2023 05:59
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkopriva, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MatousJobanek
Copy link
Contributor

/retest

@MatousJobanek
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 13, 2023
@openshift-ci openshift-ci bot removed the lgtm label Oct 13, 2023
@MatousJobanek
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 13, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
42.4% 42.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@alexeykazakov alexeykazakov merged commit 919b26a into codeready-toolchain:master Oct 13, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcoulon xcoulon xcoulon approved these changes

@sbryzak sbryzak Awaiting requested review from sbryzak

Assignees

@MatousJobanek MatousJobanek

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkopriva @MatousJobanek @xcoulon @alexeykazakov