KUBESAW-10: Rename the ToolchainCluster controller to ToolchainCluster_cache controller #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roller Signed-off-by: Feny Mehta <fbm3307@gmail.com>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
This was referenced Mar 25, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #550 +/- ##
=======================================
Coverage 84.05% 84.05%
=======================================
Files 29 29
Lines 2634 2634
=======================================
Hits 2214 2214
Misses 277 277
Partials 143 143 |
fbm3307
changed the title
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Comment on lines
+207
to
210
| if err = toolchainclustercache.NewReconciler( | ||
| mgr, | ||
| namespace, | ||
| crtConfig.ToolchainCluster().HealthCheckTimeout(), |
There was a problem hiding this comment.
The same - update also the error message:
Line 212 in b6f420e
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to Rename the ToolchainCluster controller to ToolchainCluster_cache controller
PRs in other related repos:
Toolchain Common - codeready-toolchain/toolchain-common#378
Host-Operator - codeready-toolchain/host-operator#999
Other repo PRs where the only change is to update the go.mod dependency
Registration-Service - codeready-toolchain/registration-service#418
Toolchain-e2e - codeready-toolchain/toolchain-e2e#932
Sandbox-sre - https://github.com/codeready-toolchain/sandbox-sre/pull/1633