Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward context in useraccount reconciler #494

Merged

Conversation

filariow
Copy link
Contributor

@filariow filariow commented Nov 7, 2023

Signed-off-by: Francesco Ilario filario@redhat.com

Signed-off-by: Francesco Ilario <filario@redhat.com>
Copy link

openshift-ci bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, filariow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #494 (749c6a7) into master (e87bfbe) will increase coverage by 0.06%.
The diff coverage is 81.11%.

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage   82.35%   82.42%   +0.06%     
==========================================
  Files          30       30              
  Lines        3270     3283      +13     
==========================================
+ Hits         2693     2706      +13     
  Misses        440      440              
  Partials      137      137              
Files Coverage Δ
controllers/useraccount/useraccount_controller.go 83.53% <81.11%> (+0.44%) ⬆️

Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexeykazakov alexeykazakov merged commit 58f1ee3 into codeready-toolchain:master Nov 7, 2023
9 of 10 checks passed
@filariow filariow deleted the context-useraccount branch November 8, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants