Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward context in memberstatus reconciler #497

Merged

Conversation

filariow
Copy link
Contributor

@filariow filariow commented Nov 8, 2023

Signed-off-by: Francesco Ilario filario@redhat.com

Signed-off-by: Francesco Ilario <filario@redhat.com>
@openshift-ci openshift-ci bot added the approved label Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #497 (1ea0191) into master (947c7a4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
+ Coverage   82.53%   82.54%   +0.01%     
==========================================
  Files          30       30              
  Lines        3310     3312       +2     
==========================================
+ Hits         2732     2734       +2     
  Misses        441      441              
  Partials      137      137              
Files Coverage Δ
...ontrollers/memberstatus/memberstatus_controller.go 94.31% <100.00%> (+0.04%) ⬆️

Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
6.6% 6.6% Duplication

Copy link

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, filariow, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexeykazakov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 8, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 0a2f99a into codeready-toolchain:master Nov 8, 2023
10 checks passed
@filariow filariow deleted the context-memberstatus branch November 8, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants